Conversation
dpprdan
changed the title
ability-spec
reviewed
Oct 5, 2026
ability-spec
left a comment
ability-spec
left a comment
There was a problem hiding this comment.
Small wording suggestion in docs/user-guide/preprocessing.qmd, line 223: the Narwhals example uses the named function get_median_columns_c_and_a, but the explanation still refers to a “lambda function”. There’s also a duplicated “at at” in the same sentence.
Could we change it to: “There’s a bit to unpack here, so let’s look at the preprocessing function first”?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses a lambda function for the lambda preprocessing example (again) instead of a named function.
Apparently the changes in 18a7bad went a little overboard. 😉
Related GitHub Issues and PRs
Checklist